Skip to content

Improved Heap_Sort #9596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Improved Heap_Sort #9596

wants to merge 3 commits into from

Conversation

imSanko
Copy link
Contributor

@imSanko imSanko commented Oct 3, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes rotate linked list to right by k #9258".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 3, 2023
@imSanko
Copy link
Contributor Author

imSanko commented Oct 3, 2023

@cclauss The Checks have passed, please check PR of issue > #9528

@imSanko
Copy link
Contributor Author

imSanko commented Oct 4, 2023

@cclauss The Checks have passed, please check PR of issue > #9528

Kindly Can you check once

cclauss
cclauss reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing tests and not adding type hints is not an improvement.

sorts/heap_sort.py
Comment on lines -40 to -44
>>> heap_sort([])
[]

>>> heap_sort([-2, -5, -45])
[-45, -5, -2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing tests is uncool.

@imSanko @cclauss
Update sorts/heap_sort.py
4d98dfb 
Co-authored-by: Christian Clauss <[email protected]>
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023
@imSanko imSanko closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imSanko @cclauss